Skip to content

Conversation

klausler
Copy link
Contributor

As a common extension, we support the truncation of fixed-width fields for non-list-directed input editing when a separator character (',' or ';' depending on DECIMAL='POINT' or 'COMMA' resp.) appears in the field. This isn't working for L input editing; fix.

(The bug reports a failure with DC mode, but it doesn't work with a comma either.)

Fixes #151178.

@llvmbot llvmbot added the flang Flang issues not falling into any other category label Jul 29, 2025
Copy link
Contributor

@eugeneepshteyn eugeneepshteyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

No test?

Copy link
Contributor

@DanielCChen DanielCChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks!

Copy link
Contributor

@akuhlens akuhlens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love unit tests!

As a common extension, we support the truncation of fixed-width fields for
non-list-directed input editing when a separator character
(',' or ';' depending on DECIMAL='POINT' or 'COMMA' resp.) appears
in the field.  This isn't working for L input editing; fix.

(The bug reports a failure with DC mode, but it doesn't work with a
comma either.)

Fixes llvm#151178.
@klausler klausler merged commit 35cabd6 into llvm:main Jul 30, 2025
10 checks passed
@klausler klausler deleted the bug151178 branch July 30, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[flang] Runtime error with DC editor : Part 2
5 participants